Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 26, 2025

Purpose

Update the transformers version in CI to v4.57. Also, add an upper bound to the common requirements to warn users if they try to install dev version of transformers, since vLLM is not compatible with v5 yet.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 26, 2025
@mergify mergify bot added the ci/build label Oct 26, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
chatgpt-codex-connector[bot]

This comment was marked as outdated.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to bump the transformers version, which is a reasonable maintenance task. However, this change introduces significant side effects on other dependencies that are not documented in the PR description. Most critically, the gpt-oss package and its dependencies are completely removed from requirements/test.txt. This is due to a dependency conflict where gpt-oss==0.0.8 requires transformers<4.57.0. This removal will likely break tests that rely on gpt-oss. The PR description lacks a test plan and test results, which is concerning given this major change. Additionally, several packages are downgraded, including torchgeo (from 0.7.0 to 0.6.2) and xarray (from 2025.7.1 to 2025.6.1). Downgrades can reintroduce bugs or remove features and should be justified. Please update the PR description to explain these changes and their impact, and provide a test plan to ensure that the project still works as expected.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 26, 2025 08:24
@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Oct 26, 2025

cc @Isotr0py @hmellor can you help take a look on whether the failing model initialization tests are due to outdated config format or a bug in transformers?

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py requested a review from sighingnow as a code owner October 27, 2025 13:44
@mergify mergify bot added the qwen Related to Qwen models label Oct 27, 2025
@hmellor hmellor requested a review from ywang96 as a code owner October 27, 2025 14:14
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Oct 27, 2025
@gcanlin
Copy link
Contributor

gcanlin commented Oct 28, 2025

@DarkLight1337 May I ask why the version of transformer in common.txt not updated to version 4.57.1?

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Oct 28, 2025

We don't want to force users to use the latest version, since some models are no longer compatible with v4.57. The Docker image should already be built using the latest available version even if the minimum requirement is lower.

DarkLight1337 and others added 3 commits October 28, 2025 14:44
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Copy link
Member

hmellor commented Oct 30, 2025

@DarkLight1337 all failures also appear in the latest nightly https://buildkite.com/vllm/ci/builds/36869/steps/canvas?sid=019a3346-cccf-42c2-a33c-6fcd9a50df25

We can probably force merge this

@jeejeelee
Copy link
Collaborator

All lora failures should be fixed by #27795

@DarkLight1337
Copy link
Member Author

@vllm-bot vllm-bot merged commit 879a065 into vllm-project:main Nov 1, 2025
90 of 93 checks passed
@DarkLight1337 DarkLight1337 deleted the bump-transformers branch November 1, 2025 05:11
zhaozuy pushed a commit to zhaozuy/vllm that referenced this pull request Nov 4, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
yma11 pushed a commit to yma11/vllm that referenced this pull request Nov 14, 2025
…ct#16)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants