[CI Failure] fix test_default_mm_loras #27795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
LoRA Tests are failing in nightly (https://buildkite.com/vllm/ci/builds/36869/steps/canvas?sid=019a3346-cea1-4bac-ba60-8e4eabb0c2b0, https://buildkite.com/vllm/ci/builds/36869/steps/canvas?sid=019a3346-cea1-4129-9d36-72bb43d662f6, https://buildkite.com/vllm/ci/builds/36869/steps/canvas?sid=019a3346-cea2-4b6b-a02b-b280e7d52b3b) due to recent change from PR - In LongRoPE, decide short vs long based on
max_model_len, models with LongRoPE now pick the short‑ or long‑scaling path at init time based onmax_model_len. Our LoRA default‑MM tests were usingmax_model_len=12800, which pushed Phi‑4‑MM into the long‑RoPE path and introduced tiny but deterministic output shifts, , causing brittle exact‑suffix assertions to fail in nightly.This PR changes
max_model_lenfrom 12800 to 4096 to stay on short‑RoPE.Test Plan
CI
Test Result
https://buildkite.com/vllm/ci/builds/36882/steps/canvas?sid=019a33cd-1ae3-4f0d-a8d5-a939c35eb6e2
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.