Skip to content

Conversation

@hl475
Copy link
Contributor

@hl475 hl475 commented Oct 30, 2025

Purpose

LoRA Tests are failing in nightly (https://buildkite.com/vllm/ci/builds/36869/steps/canvas?sid=019a3346-cea1-4bac-ba60-8e4eabb0c2b0, https://buildkite.com/vllm/ci/builds/36869/steps/canvas?sid=019a3346-cea1-4129-9d36-72bb43d662f6, https://buildkite.com/vllm/ci/builds/36869/steps/canvas?sid=019a3346-cea2-4b6b-a02b-b280e7d52b3b) due to recent change from PR - In LongRoPE, decide short vs long based on max_model_len, models with LongRoPE now pick the short‑ or long‑scaling path at init time based on max_model_len. Our LoRA default‑MM tests were using max_model_len=12800, which pushed Phi‑4‑MM into the long‑RoPE path and introduced tiny but deterministic output shifts, , causing brittle exact‑suffix assertions to fail in nightly.

This PR changes max_model_len from 12800 to 4096 to stay on short‑RoPE.

Test Plan

CI

Test Result

https://buildkite.com/vllm/ci/builds/36882/steps/canvas?sid=019a33cd-1ae3-4f0d-a8d5-a939c35eb6e2


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Huamin Li <3ericli@gmail.com>
@hl475 hl475 changed the title fix_test_default_mm_loras [CI Failure] fix test_default_mm_loras Oct 30, 2025
@hl475 hl475 marked this pull request as ready for review October 30, 2025 08:00
@hl475 hl475 requested a review from jeejeelee as a code owner October 30, 2025 08:00
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 30, 2025
@jeejeelee jeejeelee merged commit c7d2a55 into vllm-project:main Oct 30, 2025
47 checks passed
MatthewBonanni pushed a commit to MatthewBonanni/vllm that referenced this pull request Oct 30, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
ilmarkov pushed a commit to neuralmagic/vllm that referenced this pull request Nov 7, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
eldarkurtic pushed a commit to eldarkurtic/vllm that referenced this pull request Nov 12, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
Signed-off-by: Eldar Kurtic <8884008+eldarkurtic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants