Skip to content

Fix an endless loop issue when engine_step throws a RuntimeError #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix an endless loop issue when engine_step throws a RuntimeError #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vllm/engine/async_llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,11 @@ async def generate(

# Kick the engine if the engine is not running.
if not self.is_engine_running:
await self.engine_step(request_id)
try:
await self.engine_step(request_id)
except RuntimeError as e:
await self.abort(request_id)
raise e

# Wait for new output. The group_event will be set in engine_step
# when there is new output available for the sequence group.
Expand Down