-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support eos_token_id from generation_config.json #4182
Merged
simon-mo
merged 3 commits into
vllm-project:main
from
simon-mo:support-generation-config
Apr 19, 2024
Merged
Support eos_token_id from generation_config.json #4182
simon-mo
merged 3 commits into
vllm-project:main
from
simon-mo:support-generation-config
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgshaw2-neuralmagic
approved these changes
Apr 18, 2024
I am running vllm from docker image and facing the same issue what shall i do ? |
For now you can add To go without this extra step, we need the model checkpoint's generation config to be updated, which is pending on HF side. |
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 21, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Apr 25, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Apr 26, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 26, 2024
alexeykondrat
pushed a commit
to alexeykondrat/ci-vllm
that referenced
this pull request
May 1, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
This was referenced Jun 28, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4180
Some models uses
eos_token_id
field (Optional[Union[int, list[int]]
) ingeneration_config.json
https://huggingface.co/docs/transformers/v4.39.3/en/main_classes/text_generation#transformers.GenerationConfig
This PR will load the config, get the value if user supplied, and inject it into
stop_token_ids
in sampling params. Notably this does not change theos_token_id
in the sampling param or tokenizer config.One example is DRBX. Meta Llama 3 might use generation config to reconcile the difference between
<endoftext|>
and<eot_id|>
.Testing
Because this model dependent, I have performed manual testing: