Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] check size of the wheels #4319

Merged
merged 11 commits into from
May 4, 2024
Merged

[CI] check size of the wheels #4319

merged 11 commits into from
May 4, 2024

Conversation

simon-mo
Copy link
Collaborator

To catch #4304 early.

@simon-mo simon-mo requested a review from youkaichao May 3, 2024 05:13
simon-mo
simon-mo commented May 3, 2024
View reviewed changes
Dockerfile
@@ -3,7 +3,7 @@

#################### BASE BUILD IMAGE ####################
# prepare basic build environment
FROM nvidia/cuda:12.1.0-devel-ubuntu22.04 AS dev
FROM nvidia/cuda:12.4.1-devel-ubuntu22.04 AS dev
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12.1.0 is EOL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cuda has backward compatibility, compiling for 12.1 should work for 12.4 during runtime. But the reverse might not hold. If we compile the wheel with cuda 12.4, not sure if it works for 12.1 during runtime.

youkaichao
youkaichao approved these changes May 3, 2024
View reviewed changes
.buildkite/check-wheel-size.py Outdated
Comment on lines 14 to 15
f"Wheel {wheel_path} is too large ({wheel_size} bytes) "
f"compare to the allowed size ({MAX_SIZE} bytes).")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print the value in MB, so that it looks more human-friendly?

@simon-mo
Copy link
Collaborator Author

simon-mo commented May 3, 2024

Already catching it 🤦

#34 [build 14/15] RUN python3 check-wheel-size.py dist
--
  | #34 0.175 Wheel dist/vllm-0.4.1+cu124-cp310-cp310-linux_x86_64.whl is too large (140229157 bytes) compare to the allowed size (104857600 bytes).
  | #34 ERROR: process "/bin/sh -c python3 check-wheel-size.py dist" did not complete successfully: exit code: 1
  | ------
  | > [build 14/15] RUN python3 check-wheel-size.py dist:
  | 0.175 Wheel dist/vllm-0.4.1+cu124-cp310-cp310-linux_x86_64.whl is too large (140229157 bytes) compare to the allowed size (104857600 bytes).
  | ------

@simon-mo simon-mo enabled auto-merge (squash) May 4, 2024 18:49
@simon-mo simon-mo merged commit 021b1a2 into vllm-project:main May 4, 2024
59 checks passed
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request May 6, 2024
@simon-mo @robertgshaw2-redhat
[CI] check size of the wheels (vllm-project#4319)
c152bd7
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 7, 2024
@simon-mo @joerunde
[CI] check size of the wheels (vllm-project#4319)
71bb251
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request May 7, 2024
@simon-mo @dtrifiro
[CI] check size of the wheels (vllm-project#4319)
27b4a5c
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-mo @youkaichao