[Core][Distributed] use cpu group to broadcast metadata in cpu #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Apr 29, 2024
cadedaniel
approved these changes
Apr 29, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 6, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
mawong-amd
added a commit
to ROCm/vllm
that referenced
this pull request
Jun 4, 2024
Partially reverts [Core][Distributed] use cpu group to broadcast metadata in cpu (vllm-project#4444)
shaojiewang
pushed a commit
to shaojiewang/vllm-rocm
that referenced
this pull request
Jul 3, 2024
Partially reverts [Core][Distributed] use cpu group to broadcast metadata in cpu (vllm-project/vllm#4444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4440 , broadcasting metadata through cpu is better, because it avoids moving data back and forth between cpu and gpu.