Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move env var, so it's compatible with Windows #577

Merged
merged 19 commits into from
Mar 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN npm install --global pkg-fetch
RUN pkg-fetch -n node16 -p linux -a x64
RUN pkg-fetch -n node16 -p macos -a x64

RUN npm install --global pkg@4.3.8
RUN npm install --global pkg

# declare /vlocity_build as working directory of image
WORKDIR /vlocity_build
Expand All @@ -24,4 +24,4 @@ RUN npm install

# Important to do this final part last because of how docker builds image
# copy all remaining files/folders in project directory to the container
COPY . /vlocity_build
COPY . /vlocity_build
4 changes: 2 additions & 2 deletions lib/sfdx.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const shell = require('shelljs');

const _run = (command) => {
command = 'FORCE_COLOR=0 ' + command + ' --json';
const exec = shell.exec(command, { silent: true });
command += ' --json';
const exec = shell.exec(command, { env: { ...process.env, FORCE_COLOR: 0 }, silent: true });
let stdout;

try {
Expand Down