Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move env var, so it's compatible with Windows #577

Merged
merged 19 commits into from
Mar 21, 2023
Merged

Conversation

thvd
Copy link
Contributor

@thvd thvd commented Mar 7, 2023

Should fix: #475 (comment)

Adam Rutland and others added 18 commits October 20, 2022 15:37
* Disable Extensive Logging & Repetitions on Git Based Deploy (vlocityinc#523)
* Fixes local compilation vlocityinc#525 (vlocityinc#532)
lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.
Fixes an issue with exporting Products, etc with hyphens.
Fixes an issue with exporting Products, etc with hyphens.
Beta to Master: Batch Processing for Large Inputs
Copy link
Contributor

@KevinGossentCap KevinGossentCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be carefull, you have to add that to the env option array: ...process.env,
else you remove all use of system env var

@KevinGossentCap
Copy link
Contributor

the line should be like

const exec = shell.exec(command, { env: { ...process.env, FORCE_COLOR:0, }, silent: true });

I've tested it locally and it works :)

@thvd
Copy link
Contributor Author

thvd commented Mar 7, 2023

Should be good to go now. @KevinGossentCap thanks for testing

@manas-sf manas-sf changed the base branch from master to alpha March 21, 2023 18:35
@manas-sf manas-sf merged commit fddf478 into vlocityinc:alpha Mar 21, 2023
@thvd thvd deleted the patch-3 branch April 11, 2023 11:17
@thvd
Copy link
Contributor Author

thvd commented Apr 11, 2023

@manas-sf or @rutlabaga Do you have an ETA when this patch will be release to stable version? Because now the latest version 1.17.1 isn't working for Windows users of my team

@KevinGossentCap
Copy link
Contributor

@manas-sf As I've commented on #581 , you produced 1.71.2 tag but the version have not been released at all...
See recent issue #584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlexCard Compilation Error
4 participants