Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local compile incorrectly compiling when you're in a managed package namespace #525

Closed
deanjesper opened this issue Nov 15, 2022 · 3 comments

Comments

@deanjesper
Copy link
Contributor

If you're in a namespace such as vlocity_cmt then the local compiler is not compiling some elements correctly. One example is the cfCpqBrowsePhaseContainer FlexCard used in the LWC Cart. When compiling on-platform, all of the elements are correct, however, when using local compile, some of the elements are using c and not the namespace.

See an example below of code compiled on-platform (left) and locally (right):

Screenshot 2022-11-15 at 5 02 47 pm

This has been tested with the latest version of VBT.

Case #43628406 raised.

@thvd
Copy link
Contributor

thvd commented Nov 16, 2022

I can confirm the same. We have a case going for quite a while with number #43466400.

thvd added a commit to thvd/vlocity_build that referenced this issue Nov 17, 2022
This fixes the bug mentioned in vlocityinc#525.

I also noticed there is a file which is 99% similar: lib/datapacktypes/flexcard.js
Is there a reason for this? Or can we merge both into one?
manas-sf pushed a commit that referenced this issue Nov 21, 2022
Fixes local compilation #525
manas-sf added a commit that referenced this issue Nov 21, 2022
Fixes local compilation #525
@thvd
Copy link
Contributor

thvd commented Nov 21, 2022

@rutlabaga or @manas-sf Do you have any ETA on when this fix (#529) will be released? Then we can close this case i suppose?

manas-sf added a commit that referenced this issue Nov 21, 2022
* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)
@manas-sf
Copy link
Contributor

@thvd Please find new minor patch released - https://github.com/vlocityinc/vlocity_build/releases/tag/v1.16.1

manas-sf added a commit that referenced this issue Feb 22, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Disable colouring of SFDX CLI output

Disable colouring of SFDX CLI output so it can be JSON parsed.
Else the output of source:convert will look like this, and cannot be processed

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
manas-sf added a commit that referenced this issue Feb 22, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Adding globalkey to catalog query

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
manas-sf added a commit that referenced this issue Mar 21, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Reverting to node10 to publish 1.16.4

* Update to node14

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* New Minor Version

* Move env var, so it's compatible with Windows

* Include parent process env variables

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
Co-authored-by: Lee Skellington-McKusick <lmckusick@salesforce.com>
manas-sf added a commit that referenced this issue Mar 21, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Reverting to node10 to publish 1.16.4

* Update to node14

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* New Minor Version

* add docker image that customers/developers can use in their ci automations or to setup development environments based on containers

* remove dependabot

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
manas-sf added a commit that referenced this issue Nov 15, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Bump http-cache-semantics and salesforce-alm

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) to 4.1.1 and updates ancestor dependency salesforce-alm. These dependencies need to be updated together.


Updates `http-cache-semantics` from 3.8.1 to 4.1.1
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](https://github.com/kornelski/http-cache-semantics/commits)

Updates `salesforce-alm` from 49.5.0 to 54.8.5

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
- dependency-name: salesforce-alm
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants