Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Image #572

Merged
merged 17 commits into from
Mar 21, 2023
Merged

Add Docker Image #572

merged 17 commits into from
Mar 21, 2023

Conversation

AllanOricil
Copy link
Contributor

@AllanOricil AllanOricil commented Mar 4, 2023

I believe it is better to store this image in another repository. Could someone from Vlocityinc create a public repository to store "official" docker images? It would also be nice if vlocity could create an official Docker Hub account to publish these images. Or you could just publish these images to Github's Container Registry.

This image can be used to:

  • run CI automations.
  • create cloud or local development environments using docker containers.

obs: node-packages/package.json and sfdx-plugins/package.json both exist to keep this package up to date using Dependabot.

I also believe that there should exist official images for different purposes that Customers|Developers could use to ease their setup when developing Vlocity Applications. For instance:

vlocity-ci:1.0.0 //used for CI automations
vlocity-development-environment:1.0.0 //used to create development environments
vlocity-ci:1.0.0-alpine //alpine versions
vlocity-development-environment:1.0.0-alpine
...

With official images, Customers can quickly setup cloud or local development environments for their developers using Github Codespaces or Gitpod. Developers will no longer waste time installing all the tools they need.

Developers could add Codespaces or Gitpod badges to their README
image

This is an example of devcontainer.json that I started to use with Codespaces and VScode.

{
    "name": "Salesforce Vlocity Dev Environment",
    "image": "ghcr.io/OWNER/salesforce-build-image:v1.5.0",
    "features": {
        "ghcr.io/devcontainers/features/sshd:1": {
            "version": "latest"
        }
    },
    "hostRequirements": {
        "cpus": 4,
        "memory": "8gb",
        "storage": "32gb"
    },
    "customizations": {
        "codespaces": {
            "openFiles": ["README.md"]
        },
        "vscode": {
            "extensions": ["salesforce.salesforcedx-vscode"]
        }
    },
    "postCreateCommand": "npm install"
}

Adam Rutland and others added 16 commits October 20, 2022 15:37
* Disable Extensive Logging & Repetitions on Git Based Deploy (vlocityinc#523)
* Fixes local compilation vlocityinc#525 (vlocityinc#532)
lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.
Fixes an issue with exporting Products, etc with hyphens.
Fixes an issue with exporting Products, etc with hyphens.
…tions or to setup development environments based on containers
@AllanOricil AllanOricil changed the title Docker Image to ease the setup of the cli Add Docker Image Mar 4, 2023
@AllanOricil
Copy link
Contributor Author

@AllanOricil
Copy link
Contributor Author

Salesforce official container image
https://hub.docker.com/r/salesforce/salesforcedx/tags

@manas-sf manas-sf changed the base branch from master to alpha March 21, 2023 18:37
@manas-sf manas-sf merged commit 2bf940f into vlocityinc:alpha Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants