Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation for lwcCompiler #528

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

deanjesper
Copy link
Contributor

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Following the documentation example with 238 will just fallback on puppeteer.

Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.
@manas-sf manas-sf merged commit b358eb2 into vlocityinc:master Nov 28, 2022
manas-sf added a commit that referenced this pull request Feb 22, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Disable colouring of SFDX CLI output

Disable colouring of SFDX CLI output so it can be JSON parsed.
Else the output of source:convert will look like this, and cannot be processed

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
manas-sf added a commit that referenced this pull request Feb 22, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Adding globalkey to catalog query

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
manas-sf added a commit that referenced this pull request Mar 21, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Reverting to node10 to publish 1.16.4

* Update to node14

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* New Minor Version

* Move env var, so it's compatible with Windows

* Include parent process env variables

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
Co-authored-by: Lee Skellington-McKusick <lmckusick@salesforce.com>
manas-sf added a commit that referenced this pull request Mar 21, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Reverting to node10 to publish 1.16.4

* Update to node14

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* New Minor Version

* add docker image that customers/developers can use in their ci automations or to setup development environments based on containers

* remove dependabot

---------

Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
manas-sf added a commit that referenced this pull request Nov 15, 2023
* Update readme instructions --skip-ci

* Code Delivery 1.16.1

* Disable Extensive Logging & Repetitions on Git Based Deploy (#523)
* Fixes local compilation #525 (#532)

* Improve the documentation for lwcCompiler (#528)

lwcCompilerVersion and lwcCompilerNamespace documentation should be clearer. Currently the example is using the release version such as 236 or 238, but it needs to be the package version such as 900.469. Also examples of namespaces would be good.

* Bump http-cache-semantics and salesforce-alm

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) to 4.1.1 and updates ancestor dependency salesforce-alm. These dependencies need to be updated together.


Updates `http-cache-semantics` from 3.8.1 to 4.1.1
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](https://github.com/kornelski/http-cache-semantics/commits)

Updates `salesforce-alm` from 49.5.0 to 54.8.5

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
- dependency-name: salesforce-alm
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Adam Rutland <arutland@salesforce.com>
Co-authored-by: Manas Agarwal <manas.agarwal@salesforce.com>
Co-authored-by: Dean Hobden <dean.hobden@centrica.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants