Melee hit tables updated to classic values #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the melee roll calculations for dodge/miss/crit/parry based on the blue post here: https://us.forums.blizzard.com/en/wow/t/bug-hit-tables/185675/12 As well as data taken from the classic beta: Beta test data magey/classic-warrior#5
|
I'll upload some DPSMate screenshots of hittables after I can get a significant amount of data |
mako-taco
commented
Jun 16, 2019
| hitChance += pVictim->GetTotalAuraModifier(SPELL_AURA_MOD_ATTACKER_MELEE_HIT_CHANCE); | ||
| else { | ||
| // The first hit from gear (and likely talents) was ignored by mobs with > 10 skill difference | ||
| int32 hitFromAuras = pVictim->GetTotalAuraModifier(SPELL_AURA_MOD_ATTACKER_MELEE_HIT_CHANCE); |
There was a problem hiding this comment.
Is there a way to get the total aura modifiers from gear only? The blue post seems to indicate that talents would not be considered in this penalty.
There was a problem hiding this comment.
Both are auras, so i wouldn't think so.
|
I was actually planning on porting Guybrush's implementation. His changes are more extensive, so it seems he fixed some things you forgot. |
|
didnt know someone else worked on it already! awesome |
|
I'll comment on his PR. There are some things that I think he has implemented incorrectly. |
Velite12
pushed a commit
to Velite12/core
that referenced
this pull request
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the melee roll calculations for dodge/miss/crit/parry based on the blue post here: https://us.forums.blizzard.com/en/wow/t/bug-hit-tables/185675/12
As well as data taken from the classic beta:
Beta test data magey/classic-warrior#5