This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 489
Create a bottom panel to show secondary content #1341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like this, except one thing: IMO collapsed navigation should never be scrollable. Can the slider be positioned inside |
bryanl
force-pushed
the
create-bottom-panel
branch
2 times, most recently
from
September 17, 2020 12:42
a934972
to
907d40d
Compare
The bottom panel positions itself at the bottom of the container. It can be activated and resized to show secondary content. Signed-off-by: bryanl <bryanliles@gmail.com>
The bottom panel is disabled by default until it is fully implemented Signed-off-by: bryanl <bryanliles@gmail.com>
This is a temporary fix to allow the collapsed navigation to scroll. The ultimate fix would require navigation to present an overflow menu if it can display its full height. Signed-off-by: bryanl <bryanliles@gmail.com>
bryanl
force-pushed
the
create-bottom-panel
branch
from
September 17, 2020 12:46
907d40d
to
4a4562a
Compare
mklanjsek
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, but I am seeing following problems when testing it:
- after navigating from one page to another, the bottom panel collapses to its minimized state - I would expect it to stay open,
- the compressed side nav is broken after scrollbar has been added - it's impossible to select any items in flyout menu. The flyout menu shows up briefly, but then disappears after pointer is moved over the scrollbar,
- As commented above, I still think that bottom panel has to be be positioned inside the main pane and left navigation should go all the way to the bottom of the window,
|
mklanjsek
approved these changes
Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This set of changes creates a bottom panel component to show secondary content. This change is meant to supersede the functionality provided in the SliderView component by introducing the following features:
This change also includes:
Special notes for your reviewer:
The panel is included, but it is not activated. To see it working, set
isBottomPanelEnabled
to true in ContainerComponent and add some content toapp-bottom-panel
in the view.