This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Restore the collapsed left navigation functionality #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklanjsek
changed the title
|
@GuessWhoSamFoo Left these in since I did not find any issues with them. Please let me know if I missed something. |
|
See the screeenshot in #1359 I'm not sure of the browser/OS specifics |
Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io> Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
|
@GuessWhoSamFoo PTAL |
|
This breaks the bottom panel temporarily. We can figure out the resizing in 0.17 |
GuessWhoSamFoo
approved these changes
Sep 21, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced in #1341 inadvertently broke the left navigation in collapsed state. Namely, the flyout menu was positioned incorrectly and in some cases was not accessible after the scrollbar showed up. This change brings the old functionality back.
The Navigation component simply does not support scrolling and that will be addressed during the navigation redesign (see #1353), but for the short term (0.16 release) we should keep that functionality the way it was.
Signed-off-by: Milan Klanjsek mklanjsek@pivotal.io