This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Adding vmgroup tests #1478
Merged
Adding vmgroup tests #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/e2e/vmgroupmisc_test.go
Outdated
| // 2. Execute vmgroup ls command. | ||
| // 3. Kill the vm that was added to the tenant. | ||
| // 4. Again execute vmgroup ls command to verify command works fine. | ||
| func (s *vgBasicSuite) TestVmgroupLsPostVMKill(c *C) { |
There was a problem hiding this comment.
This test needs to be removed as this is not adding any value.
ashahi1
force-pushed
the
addVmgroupTests.ashahi1
branch
from
c10d75e
to
e80ec39
Compare
Merging this PR. |
shuklanirdesh82
approved these changes
Jun 25, 2017
shuklanirdesh82
pushed a commit
that referenced
this pull request
Jun 29, 2017
[CI SKIP] Known issue doc.liping (#1475) * Add known issue in README.md. [SKIP CI] Adds Microsoft/go-winio vendor package (#1473) This commit adds the Microsoft/go-winio vendor package, which will be used for implementing the npipe based Docker plugin for Windows. Creates platform specific config and main modules (#1482) This commit separates platform specific config and plugin serving code from the generic one. It will aid development of the Windows plugin. * Extracts unix sock service from main.go into main_linux.go. * Moves linux specific config from config.go into config_linux.go. * Renames config_test.go to config_linux_test.go. Adding a test for delete/recreate default vm group & fix cleanup in vmdk_ops_test.py (#1381) Log cleanup for VMListener : VM object not found (#1489) Update CONTRIBUTING.md Refreshing test setup requirement and bring contributing.md to current. [SKIP CI] Addressing Sam's comment revamping contributing.md Addressing Mark's comment Update CONTRIBUTING.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two tests and their related utils:
Original PR is having 3 LGTM, so this new PR is ready to merge as CI passed as well
These tests have already been reviewed in PR #1381
Had to create separate PR as one of the test related to deleting default vmgroup fails.
Ran make-testall locally and all tests pass.