This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Log cleanup for VMListener : VM object not found #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msterin
approved these changes
Jun 27, 2017
shuklanirdesh82
pushed a commit
that referenced
this pull request
Jun 29, 2017
[CI SKIP] Known issue doc.liping (#1475) * Add known issue in README.md. [SKIP CI] Adds Microsoft/go-winio vendor package (#1473) This commit adds the Microsoft/go-winio vendor package, which will be used for implementing the npipe based Docker plugin for Windows. Creates platform specific config and main modules (#1482) This commit separates platform specific config and plugin serving code from the generic one. It will aid development of the Windows plugin. * Extracts unix sock service from main.go into main_linux.go. * Moves linux specific config from config.go into config_linux.go. * Renames config_test.go to config_linux_test.go. Adding a test for delete/recreate default vm group & fix cleanup in vmdk_ops_test.py (#1381) Log cleanup for VMListener : VM object not found (#1489) Update CONTRIBUTING.md Refreshing test setup requirement and bring contributing.md to current. [SKIP CI] Addressing Sam's comment revamping contributing.md Addressing Mark's comment Update CONTRIBUTING.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanups up messy log described in #1457
Logging the exception as INFO with only logging fault message (since that's the main part).
The log now looks something like
Fixes #1457
Testing:
test-esx passes locally
// CC @msterin