Skip to content

Commit

Permalink
feat: add support for Angular 17 (#1312)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [x] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1597

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

This is not exactly port (as it was not cherrypicked) but it adds the
same change as this PR:
#1094

Tested with this PR:
#1313
  • Loading branch information
mivaylo authored Mar 12, 2024
1 parent d58d1f6 commit 4b684f8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
angular: ['Angular v15', 'Angular v16']
angular: ['Angular v15', 'Angular v16', 'Angular v17']
steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -22,11 +22,15 @@ jobs:
- name: Install Dependencies
run: npm ci
- name: Update to Angular v16
if: ${{matrix.angular == 'Angular v16'}}
if: ${{matrix.angular == 'Angular v16' || matrix.angular == 'Angular v17'}}
run: |
npx ng update @angular/core@16 @angular/common@16 @angular/cli@16 @angular/cdk@16 --force
- name: Update to Angular v17
if: ${{matrix.angular == 'Angular v17'}}
run: |
npx ng update @angular/core@17 @angular/common@17 @angular/cli@17 @angular/cdk@17 --allow-dirty --force
- name: Disable Storybook Build
if: ${{matrix.angular == 'Angular v16'}}
if: ${{matrix.angular != 'Angular v15'}}
run: node ./scripts/clear-npm-script.js _build:storybook
- name: Lint
if: ${{matrix.angular == 'Angular v15'}}
Expand Down
6 changes: 3 additions & 3 deletions projects/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
"url": "https://github.com/vmware-clarity/ng-clarity/issues"
},
"peerDependencies": {
"@angular/cdk": "15 || 16",
"@angular/common": "15 || 16",
"@angular/core": "15 || 16",
"@angular/cdk": "15 || 16 || 17",
"@angular/common": "15 || 16 || 17",
"@angular/core": "15 || 16 || 17",
"@cds/core": ">= 6.7.0"
}
}

0 comments on commit 4b684f8

Please sign in to comment.