Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Angular 17 #1312

Merged

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Mar 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-1597

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is not exactly port (as it was not cherrypicked) but it adds the same change as this PR: #1094

Tested with this PR: #1313

Copy link
Contributor

github-actions bot commented Mar 12, 2024

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@mivaylo mivaylo changed the title feat: add workflow build with angular 17 chore: add workflow build with angular 17 Mar 12, 2024
@mivaylo mivaylo force-pushed the cde-1597-set-workflow-to-build-against-angular-17-port-to-16.x branch from f282541 to dd95e09 Compare March 12, 2024 13:47
@kevinbuhmann
Copy link
Member

This is a feature, not a chore, because it adds support for v17 in the peer dependency list. Please change the PR title to feat: add support for Angular 17 or similar.

@mivaylo mivaylo changed the title chore: add workflow build with angular 17 feat: add support for Angular 17 Mar 12, 2024
@mivaylo
Copy link
Contributor Author

mivaylo commented Mar 12, 2024

This is a feature, not a chore, because it adds support for v17 in the peer dependency list. Please change the PR title to feat: add support for Angular 17 or similar.

@kevinbuhmann , updated, thanks

@mivaylo mivaylo merged commit 4b684f8 into 16.x Mar 12, 2024
7 checks passed
@mivaylo mivaylo deleted the cde-1597-set-workflow-to-build-against-angular-17-port-to-16.x branch March 12, 2024 14:42
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants