Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Angular 17 #1312

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat: add support for Angular 17 #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd95e09
feat: add workflow build with angular 17
mivaylo Mar 12, 2024
afcb455
Merge branch '16.x' into cde-1597-set-workflow-to-build-against-angul…
mivaylo Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
angular: ['Angular v15', 'Angular v16']
angular: ['Angular v15', 'Angular v16', 'Angular v17']
steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -22,11 +22,15 @@ jobs:
- name: Install Dependencies
run: npm ci
- name: Update to Angular v16
if: ${{matrix.angular == 'Angular v16'}}
if: ${{matrix.angular == 'Angular v16' || matrix.angular == 'Angular v17'}}
run: |
npx ng update @angular/core@16 @angular/common@16 @angular/cli@16 @angular/cdk@16 --force
- name: Update to Angular v17
if: ${{matrix.angular == 'Angular v17'}}
run: |
npx ng update @angular/core@17 @angular/common@17 @angular/cli@17 @angular/cdk@17 --allow-dirty --force
- name: Disable Storybook Build
if: ${{matrix.angular == 'Angular v16'}}
if: ${{matrix.angular != 'Angular v15'}}
run: node ./scripts/clear-npm-script.js _build:storybook
- name: Lint
if: ${{matrix.angular == 'Angular v15'}}
Expand Down
6 changes: 3 additions & 3 deletions projects/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
"url": "https://github.com/vmware-clarity/ng-clarity/issues"
},
"peerDependencies": {
"@angular/cdk": "15 || 16",
"@angular/common": "15 || 16",
"@angular/core": "15 || 16",
"@angular/cdk": "15 || 16 || 17",
"@angular/common": "15 || 16 || 17",
"@angular/core": "15 || 16 || 17",
"@cds/core": ">= 6.7.0"
}
}
Loading