Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid filter input field lose focus #1438

Closed
ArturSobieraj opened this issue Jun 12, 2024 · 5 comments
Closed

Datagrid filter input field lose focus #1438

ArturSobieraj opened this issue Jun 12, 2024 · 5 comments
Assignees
@dtsanevmw

Comments

@ArturSobieraj
Copy link

Describe the bug

Datagrid column filter input, lose focus while typing filter

How to reproduce

Reproductible on clarity documentation page

lost_focus

Expected behavior

Input field dont lose focus

Versions

Clarity version:

  • 16 and higher

Framework version:
Angular 17.3.7

Device:

  • Type: Dell
  • OS: Windows
  • Browser: Chrome
  • Version 125
@dtsanevmw dtsanevmw self-assigned this Jun 12, 2024
@kumart-netapp
Copy link

kumart-netapp commented Jun 13, 2024 •
edited
Loading

This is happening when the typed character had some matching records. It will not lose the focus when there are no matching records.

@ArturSobieraj
Copy link
Author

Yes, but is it correct behavior? Continue typing requires another click whats not too convenient.

@dtsanevmw dtsanevmw mentioned this issue Jun 13, 2024
Merged
13 tasks
dtsanevmw added a commit that referenced this issue Jun 13, 2024
@dtsanevmw
fix(datagrid): keep filter focus on row changes (#1442)
b866354 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

When items get filtered the input loses focus

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: #1438 

## What is the new behavior?

Focus stay on the input

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
github-actions bot pushed a commit that referenced this issue Jun 13, 2024
@dtsanevmw @github-actions
fix(datagrid): keep filter focus on row changes (#1442)
70f3115 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

When items get filtered the input loses focus

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: #1438

## What is the new behavior?

Focus stay on the input

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

(cherry picked from commit b866354)
@github-actions github-actions bot mentioned this issue Jun 13, 2024
Merged
13 tasks
dtsanevmw added a commit that referenced this issue Jun 13, 2024
@dtsanevmw
fix(datagrid): keep filter focus on row changes (#1442)
ed9417b 
Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

When items get filtered the input loses focus

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: #1438

Focus stay on the input

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

(cherry picked from commit b866354)
dtsanevmw added a commit that referenced this issue Jun 13, 2024
@github-actions @dtsanevmw
fix(datagrid): keep filter focus on row changes (backport to 16.x) (#…
f11a9a3 
…1444)

Backport b866354 from #1442. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

When items get filtered the input loses focus

&lt;!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. --&gt;

Issue Number: #1438 

## What is the new behavior?

Focus stay on the input

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Daniel Tsanev <127101685+dtsanevmw@users.noreply.github.com>
@dtsanevmw
Copy link
Contributor

Fixed and will be available in the next versions.

@repolevedavaj
Copy link
Contributor

repolevedavaj commented Jun 14, 2024 •
edited
Loading

Fixed and will be available in the next versions.

@dtsanevmw Is there already a planned release date?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dtsanevmw dtsanevmw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@repolevedavaj @ArturSobieraj @kumart-netapp @dtsanevmw