fix(datagrid): keep filter focus on row changes #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
dtsanevmw
force-pushed
the
dtsanevmw/filter_close_on_row_changes
branch
2 times, most recently
from
dcd2a35
to
d733458
Compare
valentin-mladenov
requested changes
Jun 13, 2024
projects/angular/src/data/datagrid/datagrid-virtual-scroll.directive.ts
Outdated
Show resolved
Hide resolved
dtsanevmw
force-pushed
the
dtsanevmw/filter_close_on_row_changes
branch
from
d733458
to
b683b65
Compare
dtsanevmw
force-pushed
the
dtsanevmw/filter_close_on_row_changes
branch
from
b683b65
to
0d692c3
Compare
dtsanevmw
force-pushed
the
dtsanevmw/filter_close_on_row_changes
branch
from
0d692c3
to
c854970
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? When items get filtered the input loses focus <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #1438 ## What is the new behavior? Focus stay on the input ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information (cherry picked from commit b866354)
13 tasks
dtsanevmw
added a commit
that referenced
this pull request
Jun 13, 2024
Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: When items get filtered the input loses focus <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #1438 Focus stay on the input - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> (cherry picked from commit b866354)
dtsanevmw
added a commit
that referenced
this pull request
Jun 13, 2024
…1444) Backport b866354 from #1442. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? When items get filtered the input loses focus <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #1438 ## What is the new behavior? Focus stay on the input ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Co-authored-by: Daniel Tsanev <127101685+dtsanevmw@users.noreply.github.com>
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When items get filtered the input loses focus
Issue Number: #1438
What is the new behavior?
Focus stay on the input
Does this PR introduce a breaking change?
Other information