Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): keep filter focus on row changes (backport to 16.x) #1444

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport b866354 from #1442.
## PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When items get filtered the input loses focus

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: #1438

What is the new behavior?

Focus stay on the input

Does this PR introduce a breaking change?

  • Yes
  • No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

When items get filtered the input loses focus

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: #1438

Focus stay on the input

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

(cherry picked from commit b866354)
Copy link
Contributor Author

github-actions bot commented Jun 13, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw merged commit f11a9a3 into 16.x Jun 13, 2024
7 checks passed
@dtsanevmw dtsanevmw deleted the backport-1442-to-16.x branch June 13, 2024 12:44
Copy link
Contributor Author

🎉 This PR is included in version 16.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor Author

github-actions bot commented Jul 6, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant