chore(grid-demo): move virtual rows init code back to ngOnInit
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbuhmann
force-pushed
the
kevin/virtual-rows-init
branch
from
1ee8658 to
543894b
Compare
DOM queries and subscriptions should be in `ngOnInit`, not the directive constructor. Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
kevinbuhmann
force-pushed
the
kevin/virtual-rows-init
branch
from
543894b to
4f42237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOM queries and subscriptions should be in
ngOnInit, not the directive constructor.(I will change the base to
mainonce my linting PR is merged.)