Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grid-demo): move virtual rows init code back to ngOnInit #100

Open
wants to merge 1 commit into
base: kevin/run-lint
Choose a base branch
from
Open

chore(grid-demo): move virtual rows init code back to ngOnInit #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions grid-demo/src/app/angular/row-dom-performance/custom-clr-virtual-rows.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ export class CustomClrVirtualRowsDirective<T> implements OnInit, DoCheck, OnDest
private datagridKeyNavigationController = getDatagridKeyNavigationController(this.datagrid);

private gridRoleElement: HTMLElement | null | undefined;
private virtualScrollStrategy: FixedSizeVirtualScrollStrategy | undefined;
private virtualScrollViewport: CdkVirtualScrollViewport | undefined;
private cdkVirtualFor: CdkVirtualForOf<T> | undefined;
private virtualScrollStrategy: FixedSizeVirtualScrollStrategy;
private virtualScrollViewport: CdkVirtualScrollViewport;
private cdkVirtualFor: CdkVirtualForOf<T>;
private setActiveCellSubscription: Subscription | undefined;
private dataStreamSubscription: Subscription | undefined;
private renderedRangeChangeSubscription: Subscription | undefined;
Expand All @@ -157,8 +157,6 @@ export class CustomClrVirtualRowsDirective<T> implements OnInit, DoCheck, OnDest
private readonly viewportRuler: ViewportRuler,
private readonly datagrid: ClrDatagrid
) {
this.gridRoleElement = this.datagridElementRef.nativeElement.querySelector<HTMLElement>('[role="grid"]');

this.virtualScrollStrategy = new FixedSizeVirtualScrollStrategy(
this._cdkFixedSizeVirtualScrollInputs.itemSize,
this._cdkFixedSizeVirtualScrollInputs.minBufferPx,
Expand All @@ -185,6 +183,10 @@ export class CustomClrVirtualRowsDirective<T> implements OnInit, DoCheck, OnDest
this.virtualScrollViewport,
this.ngZone
);
}

ngOnInit() {
this.gridRoleElement = this.datagridElementRef.nativeElement.querySelector<HTMLElement>('[role="grid"]');

this.updateCdkVirtualForInputs();

Expand All @@ -209,8 +211,6 @@ export class CustomClrVirtualRowsDirective<T> implements OnInit, DoCheck, OnDest
});
}

ngOnInit() {}

ngDoCheck() {
this.cdkVirtualFor?.ngDoCheck();
this.updateAriaRowIndexes();
Expand Down