Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Adds doc detail for uninstalling the Tanzu CLI #1802

Closed
wants to merge 2 commits into from

Conversation

kcoriordan
Copy link
Contributor

Signed-off-by: kcoriordan koriordan@vmware.com

What this PR does / why we need it

  • Adds detail on paths uninsalled when Tanzu uninstall.sh is run
  • Adds links to uninstall standalone/management clusters
  • Fixes naming issue - changes 'Tanzu Kubernetes Cluster' to 'Workload Cluster'

Details for the Release Notes (PLEASE PROVIDE)


Which issue(s) this PR fixes

Fixes: #1687

Describe testing done for PR

Special notes for your reviewer

Signed-off-by: kcoriordan <koriordan@vmware.com>
@kcoriordan kcoriordan requested a review from a team as a code owner September 17, 2021 14:48
@github-actions github-actions bot added the owner/docs Work executed by VMware documentation team label Sep 17, 2021
Copy link
Contributor

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kcoriordan - so sorry for the inconvinence - looks like there is a conflict as a result of us merging the docs MD linting PR: #1790

Would you be able to rebase and fix the conflict? Thanks much

@kcoriordan
Copy link
Contributor Author

I'll close this and add to another PR #1811

@kcoriordan kcoriordan closed this Sep 17, 2021
@stmcginnis
Copy link
Contributor

Just for future reference, you shouldn't need to create a whole new PR. You should be able to do the following:

git checkout main
git pull --rebase
git checkout doc-uninstall-detail
git rebase main
# fix up any issues
git add .
git commit -s --amend
git push -f origin doc-uninstall-detail

@kcoriordan
Copy link
Contributor Author

OK thanks @stmcginnis - that's really good to know, I'll try it the next time.

@kcoriordan kcoriordan deleted the doc-uninstall-detail branch September 20, 2021 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required owner/docs Work executed by VMware documentation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Give details on what uninstall does uninstall
4 participants