This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Adding doc detail for Tanzu CLI uninstall #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/docs
|
@jpmcb - I don't know how to fix the mdlindt error? |
stmcginnis
reviewed
Sep 17, 2021
There was a problem hiding this comment.
Some pretty minor errors from the mdlinting. Here is a good reference to see what those error codes mean:
https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md
So from the job output:
docs/site/content/docs/latest/cli-uninstall.md:13 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
docs/site/content/docs/latest/cli-uninstall.md:14 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "The `~/.local/share/tce` folde..."]
docs/site/content/docs/latest/cli-uninstall.md:15:1 MD019/no-multiple-space-atx Multiple spaces after hash on atx style heading [Context: "## MacOS"]
docs/site/content/docs/latest/cli-uninstall.md:15 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## MacOS"]
docs/site/content/docs/latest/cli-uninstall.md:17 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
docs/site/content/docs/latest/cli-uninstall.md:24 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
docs/site/content/docs/latest/cli-uninstall.md:27 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
docs/site/content/docs/latest/cli-uninstall.md:41 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]Looks like most are MD012: https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md012---multiple-consecutive-blank-lines
With MD032, MD019, and MD022 all coming from around the first issue on lines 13-16.
So, should be able to edit those to correct the formatting, then just:
# edit file
git add .
git commit -s --amend
git push -f origin doc-uninstall-detail
kcoriordan
force-pushed
the
doc-uninstall--detail
branch
2 times, most recently
from
c1af15a to
b92a333
Compare
Signed-off-by: kcoriordan <koriordan@vmware.com>
kcoriordan
force-pushed
the
doc-uninstall--detail
branch
from
b92a333 to
e929126
Compare
|
@stmcginnis thanks very much, very helpful as always - sorted now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kcoriordan koriordan@vmware.com
Adds detail on paths uninsalled when Tanzu uninstall.sh is run
Adds links to uninstall standalone/management clusters
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #1687
Describe testing done for PR
Special notes for your reviewer