Add package templates Antrea 0.13.3 #953
Conversation
| syncPeriod: 5m | ||
| fetch: | ||
| - imgpkgBundle: | ||
| image: projects.registry.vmware.com/tce/antrea@sha256:6a301c336c30b83c4aa704b557fc83af9e6e99af1a7242e9bdb1bd13d362402c |
There was a problem hiding this comment.
@shyaamsn how would I generate this value? I copied this from the v0.11 tempaltes
There was a problem hiding this comment.
You would push this package up to the TCE repo, then include it here. I can do that for you.
| spec: | ||
| containers: | ||
| #@overlay/match by=overlay.subset({"name":"antrea-controller"}) | ||
| - image: #@ "{}/{}:{}".format(values.imageInfo.imageRepository, values.imageInfo.images.antreaImage.imagePath, values.imageInfo.images.antreaImage.tag) |
There was a problem hiding this comment.
imageInfo is missing from values.yaml
Consider adding something like:
imageInfo:
imageRepository: www.example.com
imagePullPolicy: foo
images:
antreaImage:
imagePath: /foo/bar
tag: foobarYou can test with the following:
cd addons/packages/antrea/0.13.3/bundle/config
ytt -f values.star -f values.yaml -f kapp-config.yaml -f overlay -f upstream
There was a problem hiding this comment.
Substituting image is not supported. Could you please remove image overlay from here. Refer to 0.11.3 antrea overlay: https://github.com/vmware-tanzu/tce/blob/main/addons/packages/antrea/0.11.3/bundle/config/overlay/antrea_overlay.yaml#L183
| --- | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: antrea-config-ctb8mftc58 |
There was a problem hiding this comment.
kapp.k14s.io/versioned: "" annotation is present in antrea 0.11.3.https://github.com/vmware-tanzu/tce/blob/main/addons/packages/antrea/0.11.3/bundle/config/overlay/antrea_overlay.yaml#L171
more info about this annotation: https://carvel.dev/kapp/docs/latest/diff/#versioned-resources
| #! enterpriseAntrea: true | ||
|
|
||
| #@ end | ||
|
|
There was a problem hiding this comment.
kapp.k14s.io/versioned: "" annotation is present in antrea 0.11.3 for antrea-ca configmap. https://github.com/vmware-tanzu/tce/blob/main/addons/packages/antrea/0.11.3/bundle/config/overlay/antrea_overlay.yaml#L162
more info about this annotation: https://carvel.dev/kapp/docs/latest/diff/#versioned-resources
| type: copy | ||
| sources: [existing, new] | ||
| resourceMatchers: | ||
| - kindNamespaceNameMatcher: {kind: ConfigMap, namespace: kube-system, name: antrea-ca} |
There was a problem hiding this comment.
I assume the rebase rules for CABundle in APIService needs to be added.
https://github.com/vmware-tanzu/tce/pull/956/files
There was a problem hiding this comment.
I was going to let @nicolehanjing update it afterwards
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
andrewsykim
force-pushed
the
antrea-0.13.3
branch
from
08bd8d2 to
c575a13
Compare
andrewsykim
changed the title
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
…a@sha256:d77a9db315fa9711f74395fecd503b6d6f701592240135cd79546efd99b1e146 Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
|
@seemiller PR is ready now to be merged. Could you please take a look and merge . Thanks |
Signed-off-by: Andrew Sy Kim kim.andrewsy@gmail.com
What this PR does / why we need it
Add Antrea v0.13.3 package
Which issue(s) this PR fixes
N/A
Describe testing done for PR
TBD
Special notes for your reviewer
Does this PR introduce a user-facing change?