Skip to content

Commit

Permalink
Extract codeql from GHA linters (#5629)
Browse files Browse the repository at this point in the history
In this PR we take the `CodeQL` linter out of the GHA `linters.yml`
workflow, so it is no longer part of the `Kubeapps Main Pipeline`. We
have taken this decision because the CodeQL analysis for `golang` is
really slow (~30 min) and delays the pipelines, while the value it adds
is not so clear. That being said, we have extracted to an independent
workflow as it was before introducing the reusable linters workflow.

Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
  • Loading branch information
Jesús Miguel Benito Calzada authored Nov 11, 2022
1 parent afabf4b commit 991d3e9
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@
# SPDX-License-Identifier: Apache-2.0

---
name: CodeQL Analysis

on:
workflow_call:
inputs:
golang_version:
type: string
required: false
default: "1.19"
push:
branches: ["main"]
pull_request:
branches: ["main"]
schedule:
- cron: "0 5 * * *"

jobs:
analyze:
Expand Down Expand Up @@ -36,7 +38,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: ${{ inputs.golang_version }}
go-version: 1.19
if: ${{ matrix.language == 'go' }}

# Initializes the CodeQL tools for scanning.
Expand Down
14 changes: 0 additions & 14 deletions .github/workflows/codeql-scheduled.yml

This file was deleted.

5 changes: 0 additions & 5 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,3 @@ jobs:
- uses: actions/checkout@v3
- name: Check license Headers
uses: apache/skywalking-eyes/header@v0.4.0

CodeQL:
uses: ./.github/workflows/codeql-reusable.yml
with:
golang_version: ${{ inputs.golang_version }}

0 comments on commit 991d3e9

Please sign in to comment.