Extract codeql from GHA linters #5629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
beni0888
added
component/ci
added 2 commits
November 11, 2022 07:50
antgamdia
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
In this PR we take the
CodeQLlinter out of the GHAlinters.ymlworkflow, so it is no longer part of theKubeapps Main Pipeline. We have taken this decision because the CodeQL analysis forgolangis really slow (~30 min) and delays the pipelines, while the value it adds is not so clear. That being said, we have extracted to an independent workflow as it was before introducing the reusable linters workflow.Benefits
Kubeapps Main Pipelinethat is run for every PR and push to master is not delayed because of the CodeQL analysis.Possible drawbacks
N/A
Applicable issues