Auto generate release name (#877)

vmware-tanzu · Dec 17, 2018 · e1b2f19 · e1b2f19
1 parent 84b6a15
commit e1b2f19
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 2 deletions.
diff --git a/dashboard/package.json b/dashboard/package.json
@@ -17,6 +17,7 @@
     "enzyme-adapter-react-16": "^1.1.1",
     "js-yaml": "^3.10.0",
     "lodash": "^4.17.11",
+    "moniker-native": "^0.1.6",
     "protobufjs": "^6.8.4",
     "qs": "^6.5.2",
     "raf": "^3.4.0",

diff --git a/dashboard/src/components/DeploymentForm/DeploymentForm.test.tsx b/dashboard/src/components/DeploymentForm/DeploymentForm.test.tsx
@@ -95,5 +95,15 @@ it("renders the full DeploymentForm", () => {
   const wrapper = shallow(
     <DeploymentForm {...defaultProps} selected={{ versions, version: versions[0] }} />,
   );
+  // Force static name
+  wrapper.setState({ releaseName: "bar" });
   expect(wrapper).toMatchSnapshot();
 });
+
+it("renders a release name by default", () => {
+  const versions = [{ id: "foo", attributes: { version: "1.2.3" } }] as IChartVersion[];
+  const wrapper = shallow(
+    <DeploymentForm {...defaultProps} selected={{ versions, version: versions[0] }} />,
+  );
+  expect(wrapper.state("releaseName")).toBeTruthy();
+});
diff --git a/dashboard/src/components/DeploymentForm/DeploymentForm.tsx b/dashboard/src/components/DeploymentForm/DeploymentForm.tsx
@@ -1,4 +1,5 @@
 import { RouterAction } from "connected-react-router";
+import * as Moniker from "moniker-native";
 import * as React from "react";
 import AceEditor from "react-ace";
 
@@ -46,7 +47,7 @@ class DeploymentForm extends React.Component<IDeploymentFormProps, IDeploymentFo
     appValues: undefined,
     isDeploying: false,
     namespace: this.props.namespace,
-    releaseName: "",
+    releaseName: Moniker.choose(),
     latestSubmittedReleaseName: "",
     valuesModified: false,
   };

diff --git a/dashboard/src/components/DeploymentForm/__snapshots__/DeploymentForm.test.tsx.snap b/dashboard/src/components/DeploymentForm/__snapshots__/DeploymentForm.test.tsx.snap
@@ -37,7 +37,7 @@ exports[`renders the full DeploymentForm 1`] = `
             pattern="[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*"
             required={true}
             title="Use lower case alphanumeric characters, '-' or '.'"
-            value=""
+            value="bar"
           />
         </div>
         <div>

diff --git a/dashboard/yarn.lock b/dashboard/yarn.lock
@@ -6776,6 +6776,11 @@ mock-socket@^8.0.2:
   dependencies:
     url-parse "^1.2.0"
 
+moniker-native@^0.1.6:
+  version "0.1.6"
+  resolved "https://registry.yarnpkg.com/moniker-native/-/moniker-native-0.1.6.tgz#019af026841c32c78edb420695c14b24dd095d09"
+  integrity sha1-AZrwJoQcMseO20IGlcFLJN0JXQk=
+
 moo@^0.4.3:
   version "0.4.3"
   resolved "https://registry.yarnpkg.com/moo/-/moo-0.4.3.tgz#3f847a26f31cf625a956a87f2b10fbc013bfd10e"