Auto generate release name #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
approved these changes
Dec 13, 2018
| expect(wrapper).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it("renders a release name by default", () => { |
There was a problem hiding this comment.
You could potentially mock Moniker to test that its generation is the value set and changes between mounts.
There was a problem hiding this comment.
I'd avoid all the sinon/stub integration just for that.
There was a problem hiding this comment.
Why is that? You do not need to use sinon but jest.
I think that the key here is if you care about testing that the value set as name changes and depends on an autogenerated value. Which is not being tested in your case.
There was a problem hiding this comment.
ah, well, in that case it's not necessary to mock the behavior just to check that the release name has a length bigger than 0 and that it changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #485
Auto generate a random name for the release using moniker.