[Chart] frontend service annotation #587
Conversation
migmartri
changed the title
| @@ -92,6 +92,7 @@ frontend: | |||
| service: | |||
| port: 80 | |||
| type: ClusterIP | |||
| # annotations: {} | |||
There was a problem hiding this comment.
Why commenting it out? if it is empty, it doesn't need to be commented out. And the rest of optional values (like tolerations) are not commented out. Is this a special case?
There was a problem hiding this comment.
Thanks for catching the inconsistency, no, it is not a special case, I think I just left it like that by mistake because I was testing the differences between range used upstream https://github.com/helm/charts/blob/master/stable/wordpress/templates/ingress.yaml#L16 and with values that we use in this chart.
My bad, sorry.
There was a problem hiding this comment.
Actually, it seems that it is consistent with the way we use annotations in the ingress.
There was a problem hiding this comment.
Actually commented out vs empty object in the values.yaml file does not seem to make any difference, so I am wondering why we commented it out in the ingress in the first place Maybe @prydonius could shed some light?
With the current commented out value, no annotation added
helm template . -x templates/kubeapps-frontend-service.yaml
---
# Source: kubeapps/templates/kubeapps-frontend-service.yaml
apiVersion: v1
kind: Service
metadata:
name: RELEASE-NAME-kubeapps
labels:
app: kubeapps
chart: kubeapps-0.4.0
release: RELEASE-NAME
heritage: Tiller
spec:Using the empty object approach instead, no annotation added either
git diff
diff --git a/chart/kubeapps/values.yaml b/chart/kubeapps/values.yaml
index fa97086c..7b65f76c 100644
--- a/chart/kubeapps/values.yaml
+++ b/chart/kubeapps/values.yaml
@@ -92,7 +92,7 @@ frontend:
service:
port: 80
type: ClusterIP
- # annotations: {}
+ annotations: {}
livenessProbe:
helm template . -x templates/kubeapps-frontend-service.yaml
---
# Source: kubeapps/templates/kubeapps-frontend-service.yaml
apiVersion: v1
kind: Service
metadata:
name: RELEASE-NAME-kubeapps
labels:
app: kubeapps
chart: kubeapps-0.4.0
release: RELEASE-NAME
heritage: Tiller
spec:There was a problem hiding this comment.
In case that we decide to change it, I went ahead and created a patch for it #599
It sdds support for metadata annotations to the frontend service.
This is useful if the user opts for exposing kubeapps via a LoadBalancer but want to tweak it by making it for example internal
'service.beta.kubernetes.io/aws-load-balancer-internal: 0.0.0.0/0'I have not modified the Readme because in my opinion, this is a power user feature, disabled by default, and not commonly required.