Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make annotations defaults consistent #599

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

migmartri
Copy link
Contributor

@migmartri migmartri commented Sep 7, 2018

Based on this discussion https://github.com/kubeapps/kubeapps/pull/587/files#r215954708

See below the comparative based on the template render before and after the change with ingress enabled:

helm template . --set ingress.enabled=true > /tmp/[before/after]_change.yaml

The change does not affect the default outputs, the mongoDB password is expected to be generated

diff /tmp/before_change.yaml /tmp/after_change.yaml 
14c14
<   mongodb-root-password: "TTI2Qlc0dXY2Sg=="
---
>   mongodb-root-password: "NVplRXVTVVRvcQ=="

Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@arapulido arapulido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@migmartri migmartri merged commit 1c82b9f into vmware-tanzu:master Sep 10, 2018
@migmartri migmartri deleted the remove-chart-inconsistency branch September 10, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants