Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inclusivity: refactor instances of masterKey in the source code as rootKey #555

Closed
v0lkan opened this issue Feb 18, 2024 · 4 comments
Closed

inclusivity: refactor instances of masterKey in the source code as rootKey #555

v0lkan opened this issue Feb 18, 2024 · 4 comments
Assignees
@omergk28
Labels
cleanup good first issue Good for newcomers

Comments

@v0lkan
Copy link
Contributor

v0lkan commented Feb 18, 2024

No description provided.

@v0lkan v0lkan added good first issue Good for newcomers cleanup labels Feb 18, 2024
@v0lkan
Copy link
Contributor Author

v0lkan commented Feb 18, 2024

This is also for consistency because the documentation refers the key as “root key”, not “master key”.

@omergk28
Copy link
Contributor

/assign

@v0lkan
Copy link
Contributor Author

v0lkan commented Feb 19, 2024

assigned.

omergk28 pushed a commit to omergk28/secrets-manager that referenced this issue Feb 25, 2024
@v0lkan @omergk28
inclusivity(VSecM): update log message to use more inclusive language (…
5d9567f 
…vmware-tanzu#555)

Signed-off-by: Omer Kocaoglu <omergk28@gmail.com>

🌟 enhancement(VSecM): helm template changes (vmware-tanzu#558)

Tested in the build server — everything appears to be in order.
Landing this.

* 🌟 enhancement(VSecM): helm template changes

This PR introduces the ability for VSecM Safe to use a persistent volume if
provided.

There are also additional variable renames and refactorings to make the code
clearer.

In addition, certain missing environment variables have been added to Helm
charts and certain environment variables that were not being used (*and
appear to have been mistakenly injected*) to containers have been removed.

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* 💄 cosmetic(VSecM): code refactoring

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* test function rename

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* 💄 cosmetic(VSecM): method and var renames for clarity

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* minor

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

---------

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Omer Kocaoglu <omergk28@gmail.com>
@v0lkan
Copy link
Contributor Author

v0lkan commented Feb 27, 2024

This appears to be done.

Closing it.

@v0lkan v0lkan closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omergk28 omergk28

Labels
cleanup good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@v0lkan @omergk28