Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌟 enhancement(VSecM): helm template changes #558

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Feb 23, 2024

This PR introduces the ability for VSecM Safe to use a persistent volume if provided.

There are also additional variable renames and refactorings to make the code clearer.

In addition, certain missing environment variables have been added to Helm charts and certain environment variables that were not being used (and appear to have been mistakenly injected) to containers have been removed.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project’s license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project’s license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

This PR introduces the ability for VSecM Safe to use a persistent volume if
provided.

There are also additional variable renames and refactorings to make the code
clearer.

In addition, certain missing environment variables have been added to Helm
charts and certain environment variables that were not being used (*and
appear to have been mistakenly injected*) to containers have been removed.

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
@v0lkan v0lkan merged commit b5086a6 into main Feb 23, 2024
@v0lkan v0lkan deleted the ovolkan/helm-chart-change branch February 23, 2024 20:56
omergk28 pushed a commit to omergk28/secrets-manager that referenced this pull request Feb 25, 2024
…vmware-tanzu#555)

Signed-off-by: Omer Kocaoglu <omergk28@gmail.com>

🌟 enhancement(VSecM): helm template changes (vmware-tanzu#558)

Tested in the build server — everything appears to be in order.
Landing this.

* 🌟 enhancement(VSecM): helm template changes

This PR introduces the ability for VSecM Safe to use a persistent volume if
provided.

There are also additional variable renames and refactorings to make the code
clearer.

In addition, certain missing environment variables have been added to Helm
charts and certain environment variables that were not being used (*and
appear to have been mistakenly injected*) to containers have been removed.

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* 💄 cosmetic(VSecM): code refactoring

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* test function rename

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* 💄 cosmetic(VSecM): method and var renames for clarity

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

* minor

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>

---------

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
Signed-off-by: Omer Kocaoglu <omergk28@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant