Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in extra volumes handling #397

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Fix bug in extra volumes handling #397

merged 1 commit into from
Mar 26, 2018

Conversation

liztio
Copy link
Contributor

@liztio liztio commented Mar 26, 2018

Signed-off-by: liz liz@heptio.com

What this PR does / why we need it:
We were not actually passing extra-volumes through to the plugins loader/template filler.

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

@liztio
Fix bug in extra volumes handling
9530332 
Signed-off-by: liz <liz@heptio.com>
chuckha
chuckha approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this was tested locally, lgtm

@liztio
Copy link
Contributor Author

liztio commented Mar 26, 2018 

time="2018-03-26T16:51:48Z" level=info msg="Starting server Expected Results: [{gke-k8s-test-default-pool-5a0efaee-1qzr docker_cis} {gke-k8s-test-default-pool-5a0efaee-lr16 docker_cis} {gke-k8s-test-default-pool-5a0efaee-p6q9 docker_cis}]"
time="2018-03-26T16:51:48Z" level=info msg="Running plugin" plugin=docker-cis
time="2018-03-26T16:51:48Z" level=info msg="starting aggregation server" address=0.0.0.0 port=8080

@liztio liztio mentioned this pull request Mar 26, 2018
Merged
@liztio liztio merged commit 3347839 into vmware-tanzu:master Mar 26, 2018
@liztio liztio deleted the fix-extravolumes-bug branch March 26, 2018 16:54
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this pull request Jun 27, 2018
@liztio
Fix bug in extra volumes handling (vmware-tanzu#397)
b49e022 
Signed-off-by: liz <liz@heptio.com>
Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this pull request Jun 27, 2018
@liztio
Fix bug in extra volumes handling (vmware-tanzu#397)
d60d3a2 
Signed-off-by: liz <liz@heptio.com>
Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com

Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
ceridwen pushed a commit to ceridwen/sonobuoy that referenced this pull request Jul 19, 2018
@liztio @ceridwen
Fix bug in extra volumes handling (vmware-tanzu#397)
e09d195 
Signed-off-by: liz <liz@heptio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckha chuckha chuckha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to add new VolumeMounts to latest version of Sonobuoy plugins
2 participants
@liztio @chuckha