Re-add sonobuoy gen plugin.
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super helpful for debugging plugin generation. Signed-off-by: liz <liz@heptio.com>
timothysc
reviewed
Apr 2, 2018
|
|
||
| func init() { | ||
| cmd := &cobra.Command{ | ||
| Use: "plugin", |
There was a problem hiding this comment.
This doesn't look like a sub-command of gen, but it's own sub-command of the root? Is that what you want?
There was a problem hiding this comment.
I add it to GenCommand, so I think it'll be a subcommand of that, no?
timothysc
reviewed
Apr 2, 2018
| "the paths to search for the plugins in. Defaults to . and ./plugins.d/", | ||
| ) | ||
| // TODO: Other options? | ||
| GenCommand.AddCommand(cmd) |
|
@liztio go ahead and rebase and merge... |
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Re-add `sonobuoy gen plugin`. Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Re-add `sonobuoy gen plugin`. Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super helpful for debugging plugin generation.
Signed-off-by: liz liz@heptio.com
What this PR does / why we need it:
I used this in testing #397. I've needed it enough that I figured I might as well just add it back in.
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: