✨ Introduce WCP_TKG_Multiple_CL FSS in vm-operator #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridaz
force-pushed
the
topic/ridaz/multi-cl
branch
from
956fcb6 to
95e2651
Compare
ridaz
force-pushed
the
topic/ridaz/multi-cl
branch
from
95e2651 to
ca29665
Compare
|
@ridaz Can you please squash all of your commits before removing the WiP label? Thanks! |
akutz
reviewed
Mar 5, 2024
ridaz
force-pushed
the
topic/ridaz/multi-cl
branch
from
0a1f6ce to
5dc5c20
Compare
github-actions
bot
added
size/M
ridaz
changed the title
akutz
reviewed
Mar 11, 2024
...rs/contentlibrary/v1alpha2/clustercontentlibraryitem/clustercontentlibraryitem_controller.go
Outdated
Show resolved
Hide resolved
...rs/contentlibrary/v1alpha2/clustercontentlibraryitem/clustercontentlibraryitem_controller.go
Outdated
Show resolved
Hide resolved
ridaz
changed the title
ridaz
force-pushed
the
topic/ridaz/multi-cl
branch
3 times, most recently
from
0476dcf to
cedd33b
Compare
akutz
reviewed
Mar 12, 2024
akutz
reviewed
Mar 12, 2024
ridaz
force-pushed
the
topic/ridaz/multi-cl
branch
from
cedd33b to
3f36fdf
Compare
ridaz
force-pushed
the
topic/ridaz/multi-cl
branch
from
3f36fdf to
6cc21e0
Compare
akutz
approved these changes
Mar 12, 2024
Minimum allowed line rate is |
akutz
added a commit
to akutz/vm-operator
that referenced
this pull request
Jan 28, 2025
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via vmware-tanzu#406 but were accidentally removed via vmware-tanzu#851. When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
akutz
added a commit
to akutz/vm-operator
that referenced
this pull request
Jan 28, 2025
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via vmware-tanzu#406 but were accidentally removed via vmware-tanzu#851. When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
akutz
added a commit
to akutz/vm-operator
that referenced
this pull request
Jan 28, 2025
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via vmware-tanzu#406 but were accidentally removed via vmware-tanzu#851. When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
akutz
added a commit
to akutz/vm-operator
that referenced
this pull request
Jan 28, 2025
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via vmware-tanzu#406 but were accidentally removed via vmware-tanzu#851. When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
akutz
added a commit
to akutz/vm-operator
that referenced
this pull request
Jan 28, 2025
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via vmware-tanzu#406 but were accidentally removed via vmware-tanzu#851. When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
bryanv
pushed a commit
to bryanv/vm-operator
that referenced
this pull request
Jan 29, 2025
This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via vmware-tanzu#406 but were accidentally removed via vmware-tanzu#851. When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This PR will bring in the following changes:
Adding support for WCP_TKG_Multiple_CL in the following :
a. YAML Changes
- config/local/vmoperator/local_env_var_patch.yaml
- config/wcp/vmoperator/manager_env_var_patch.yaml
b. Adding a new variable for TKGMultipleCL
- pkg/config/config.go
- pkg/config/default.go
- pkg/config/env.go
- pkg/config/env/env.go
c. Updating the variable
TKGMultipleCLas env variable in UTs inpkg/config/env_test.goUpdating the reconcile logic in
setUpCVMIFromCCLItemto update the labels on if the labels exists in CCLItems.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #427
Are there any special notes for your reviewer:
Please add a release note if necessary: