Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing labels on CVMI resources #873

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix missing labels on CVMI resources #873

merged 1 commit into from
Jan 30, 2025

Conversation

bryanv
Copy link
Contributor

@bryanv bryanv commented Jan 29, 2025

What does this PR do, and why is it needed?

This patch fixes an issue where the labels on the CVMI resources from the CCLI resources were missing. The labels were added via #406 but were accidentally removed via
#851.

When adding them back, there are now also tests to validate the logic works as there were no tests in the original PR.

Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

Are there any special notes for your reviewer:

Fixes #872 on 9.0 release branch

Please add a release note if necessary:

NONE

@akutz
Fix missing labels on CVMI resources
ace8889 
This patch fixes an issue where the labels on the CVMI resources
from the CCLI resources were missing. The labels were added via
vmware-tanzu#406 but were
accidentally removed via
vmware-tanzu#851.

When adding them back, there are now also tests to validate the
logic works as there were no tests in the original PR.
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jan 29, 2025
@aruneshpa
Copy link
Contributor

Assuming this is a straight cherry pick, LGTM.

akutz
akutz approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bryanv !

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem 100% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem 100% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils 89% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/configmap 86% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/crd 93% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap 71% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/node 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/secret 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/validatingwebhookconfiguration 85% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/zone 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/storageclass 95% ✔
github.com/vmware-tanzu/vm-operator/controllers/storagepolicyquota 97% ✔
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/storagepolicyusage 98% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/virtualmachine 69% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volume 87% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass 75% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineimagecache 89% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset 68% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice 83% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy 82% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/bitmask 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/builder 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/conditions 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/config 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/capabilities 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/env 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context/generic 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context/operation 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/errors 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/mem 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/client 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary 72% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session 71% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/storage 44% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/sysprep 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine 84% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle 62% ❌
github.com/vmware-tanzu/vm-operator/pkg/record 87% ➖
github.com/vmware-tanzu/vm-operator/pkg/topology 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/image 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 89% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/kube/cource 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/proxyaddr 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/kube/spq 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/netplan 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/paused 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ptr 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize 97% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 81% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client 64% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/library 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 79% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/watcher 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/crypto 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 100% ✔
github.com/vmware-tanzu/vm-operator/services/vm-watcher 93% ✔
github.com/vmware-tanzu/vm-operator/webhooks/common 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/unifiedstoragequota/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation 87% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation 62% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation 89% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation 67% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/validation 92% ✔
Summary 82% (11333 / 13760) ➖

Minimum allowed line rate is 79%

@akutz akutz merged commit 33d8f75 into vmware-tanzu:release/vc-9.0.0 Jan 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruneshpa aruneshpa aruneshpa approved these changes

@akutz akutz akutz approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanv @aruneshpa @akutz