Close TCP connection in case of error #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better than keeping the connection open, as it sends a signal to the exporter that something is wrong. This is also one of the four possible behaviors described by RFC7011 for handling malformed IPFIX messages for TCP and SCTP connections. See https://datatracker.ietf.org/doc/html/rfc7011#section-9.1. Note that implementing one of these four options is not mandatory. However, the RFC also states that: > the Collecting Process SHOULD stop processing IPFIX Messages > from clearly malfunctioning Exporting Processes (e.g., those from > which the last few IPFIX Messages have been malformed). Closing the TCP connection is the easiest thing for us to implement, and it makes sense to use IMO. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
commented
Nov 22, 2024
| go func() { | ||
| defer cp.wg.Done() | ||
| defer close(doneCh) |
There was a problem hiding this comment.
this could also be considered a bug fix. Prior to this commit, return statements in the for loop would cause this goroutine to return, but we would block on cp.stopChan indefinitely (so I think there would be a goroutine leak, as the parent goroutine, which invoked handleTCPClient would never return).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better than keeping the connection open, as it sends a signal to the exporter that something is wrong.
This is also one of the four possible behaviors described by RFC7011 for handling malformed IPFIX messages for TCP and SCTP connections. See https://datatracker.ietf.org/doc/html/rfc7011#section-9.1. Note that implementing one of these four options is not mandatory. However, the RFC also states that:
Closing the TCP connection is the easiest thing for us to implement, and it makes sense to use IMO.