Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close TCP connection in case of error #384

Merged

Commits on Nov 22, 2024

  1. Close TCP connection in case of error

    This is better than keeping the connection open, as it sends a signal to
    the exporter that something is wrong.
    
    This is also one of the four possible behaviors described by RFC7011 for
    handling malformed IPFIX messages for TCP and SCTP connections. See
    https://datatracker.ietf.org/doc/html/rfc7011#section-9.1. Note that
    implementing one of these four options is not mandatory. However, the
    RFC also states that:
    
    > the Collecting Process SHOULD stop processing IPFIX Messages
    > from clearly malfunctioning Exporting Processes (e.g., those from
    > which the last few IPFIX Messages have been malformed).
    
    Closing the TCP connection is the easiest thing for us to implement, and
    it makes sense to use IMO.
    
    Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
    antoninbas committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    03d9c68 View commit details
    Browse the repository at this point in the history