Update ALB service engine group and ALB settings to support SupportedFeatureSet in VCD 10.4 #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
commented
Jun 24, 2022
adambarreiro
changed the title
adambarreiro
changed the title
adambarreiro
changed the title
adambarreiro
requested review from
lvirbalas,
Didainius and
vbauzys
as code owners
Signed-off-by: abarreiro <abarreiro@vmware.com>
|
Moving back to Draft as I got some test results today that showed that also changes in Edge Gateway must also be done. |
added 5 commits
June 27, 2022 10:44
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
changed the title
adambarreiro
commented
Jun 29, 2022
adambarreiro
commented
Jun 29, 2022
adambarreiro
commented
Jun 29, 2022
|
Please expand the Description of this PR with context of why this is needed, what has changed in VCD and in which version. Thanks! |
adambarreiro
changed the title
Updated, please check now. Please let me know whether I should change something else or if it's OK now! |
4 tasks
Didainius
approved these changes
Jul 8, 2022
adambarreiro
changed the title
added 4 commits
July 19, 2022 09:31
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not associated to any issue.
Description
When executing the tests using VCD 10.4, I found that some of them were failing due to:
LicenseTypeattribute in 10.4 (v37.0)SupportedFeatureSetin 10.4 (v37.0) that replaces the aboveLicenseTypeSupportedFeatureSetin 10.4 (v37.0) that replaces the aboveLicenseTypeThe goal of this PR is to adapt the mentioned data structures to make the Go SDK compatible with v37.0 of the API (VCD 10.4).
In consequence, the failing tests have been adapted and some functions now use
getOpenApiHighestElevatedVersionto support both old and new scenarios.Tests