Update ALB service engine group and ALB settings to add supported_feature_set for VCD 10.4 #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 30, 2022 15:52
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
requested review from
lvirbalas,
Didainius and
vbauzys
as code owners
added 2 commits
July 1, 2022 13:32
Didainius
reviewed
Jul 9, 2022
adambarreiro
changed the title
added 3 commits
July 18, 2022 17:17
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
adambarreiro
commented
Jul 26, 2022
added 7 commits
July 26, 2022 14:50
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…o/terraform-provider-vcd into update-avi-licensing Signed-off-by: abarreiro <abarreiro@vmware.com>
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
Didainius
reviewed
Jul 28, 2022
Didainius
reviewed
Jul 28, 2022
Didainius
reviewed
Jul 28, 2022
Didainius
reviewed
Jul 28, 2022
Didainius
reviewed
Jul 28, 2022
Didainius
approved these changes
Jul 28, 2022
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not associated to any issue.
This PR depends on vmware/go-vcloud-director#485
Description
When executing the tests using VCD 10.4, I found that some of them were failing due to:
license_typeattribute from 10.4 (v37.0) onwardssupported_feature_setattribute to be compatible with 10.4 (v37.0) that replaces the abovelicense_typesupported_feature_setattribute to be compatible with 10.4 (v37.0) that replaces the abovelicense_typeThe goal of this PR is to adapt the mentioned resources and data sources to make the Terraform Provider compatible with v37.0 of the API (VCD 10.4).
In consequence, the failing tests have been adapted and resources and datasources have changed the mentioned required/optional attributes.
Tests
albtag passes on any VCD