vApp template capture support #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
force-pushed
the
capture-template
branch
from
1ea8672 to
34472c2
Compare
Didainius
force-pushed
the
capture-template
branch
from
34472c2 to
10fb69d
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
capture-template
branch
from
890fda1 to
20cf048
Compare
Didainius
commented
Mar 5, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adambarreiro
reviewed
Mar 6, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
reviewed
Mar 7, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to create vApp template from existing vApp or standalone VMs (which also have vApps, they're just hidden). The functionality is called "capture vApp template" and the functionality is introduced using
Catalog.CaptureVappTemplate,Catalog.CaptureVappTemplateAsyncand typetypes.CaptureVAppParamsAdditionally there are some covenience changes in the code:
VApp.GetParentVDCbecomes public (previously it was private method)Org.GetVAppByHrefto retrieve a vApp by given HREFVAppTemplate.GetCatalogItemHrefandVAppTemplate.GetCatalogItemIdthat can returnrelated catalog item ID and HREF of a vApp template