Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Enable request/response logging #34

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Conversation

roidelapluie
Copy link
Contributor

This makes debugging for developers & users of this provider easier by
exposing all requests & responses in the log (when >DEBUG severity is
set).

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

This makes debugging for developers & users of this provider easier by
exposing all requests & responses in the log (when >DEBUG severity is
set).

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
@ghost ghost added the size/XS label Nov 15, 2019
Copy link
Contributor

@Prativa20 Prativa20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@markpeek markpeek merged commit f8674c1 into vmware:master Apr 12, 2020
@markpeek
Copy link
Contributor

@roidelapluie Oops...just occurred to me, this should use terraform-plugin-sdk logging instead of the terraform.

@roidelapluie
Copy link
Contributor Author

@roidelapluie Oops...just occurred to me, this should use terraform-plugin-sdk logging instead of the terraform.

No because this plugin has not been migrated yet. see #58 for the migration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants