Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Move to terraform-sdk #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

roidelapluie
Copy link
Contributor

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

@markpeek
Copy link
Contributor

Thanks @roidelapluie for this PR. I thought we had already switched this provider to the plugin sdk. For the lint issue, this patch will fix it:

$ git diff
diff --git a/.golangci.yml b/.golangci.yml
index f5f30a7..7498496 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -20,7 +20,7 @@ linters:

 linters-settings:
   errcheck:
-    ignore: github.com/hashicorp/terraform/helper/schema:ForceNew|Set,fmt:.*,io:Close
+    ignore: github.com/hashicorp/terraform-plugin-sdk/helper/schema:ForceNew|Set,fmt:.*,io:Close

 run:
   deadline: 5m

For the unit test issue, @Prativa20 should take a look at this branch. Note: I did try to update terraform-plugin-sdk to v1.9.1 but same issue.

@roidelapluie
Copy link
Contributor Author

Thanks @roidelapluie for this PR. I thought we had already switched this provider to the plugin sdk. For the lint issue, this patch will fix it:

Applied.

For the unit test issue, @Prativa20 should take a look at this branch. Note: I did try to update terraform-plugin-sdk to v1.9.1 but same issue.

Updated to v1.9.1 and fixed the test.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants