Skip to content

Commit

Permalink
Merge pull request #408 from gaocegege/defaults
Browse files Browse the repository at this point in the history
fix: Add comments about the defaulting of queue
  • Loading branch information
volcano-sh-bot authored Aug 7, 2019
2 parents 41fad21 + ab3a5f4 commit 370d612
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion pkg/apis/scheduling/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ type PodGroupSpec struct {
MinMember int32 `json:"minMember,omitempty" protobuf:"bytes,1,opt,name=minMember"`

// Queue defines the queue to allocate resource for PodGroup; if queue does not exist,
// the PodGroup will not be scheduled.
// the PodGroup will not be scheduled. Defaults to `default` Queue with the lowest weight.
// +optional
Queue string `json:"queue,omitempty" protobuf:"bytes,2,opt,name=queue"`

// If specified, indicates the PodGroup's priority. "system-node-critical" and
Expand Down
3 changes: 2 additions & 1 deletion pkg/apis/scheduling/v1alpha2/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ type PodGroupSpec struct {
MinMember int32 `json:"minMember,omitempty" protobuf:"bytes,1,opt,name=minMember"`

// Queue defines the queue to allocate resource for PodGroup; if queue does not exist,
// the PodGroup will not be scheduled.
// the PodGroup will not be scheduled. Defaults to `default` Queue with the lowest weight.
// +optional
Queue string `json:"queue,omitempty" protobuf:"bytes,2,opt,name=queue"`

// If specified, indicates the PodGroup's priority. "system-node-critical" and
Expand Down

0 comments on commit 370d612

Please sign in to comment.