Skip to content

Conversation

@connortsui20
Copy link
Contributor

Makes sure each compute function implementation has its own file.

Note that this is a purely cosmetic change.

Yes, this is verbose, but also it's better to be consistent (and it also helps with discoverability, for example "which compute functions exist for this array type?).

Make sure each compute function implementation has its own file. Yes,
this is verbose, but also it's better to be consistent (and it also
helps with discoverability, for example "which compute functions exist
for this array type?).

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the chore Release label indicating a trivial change label Oct 17, 2025
@codspeed-hq

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.28%. Comparing base (4de2926) to head (3f22c1c).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/arrays/struct_/compute/take.rs 70.83% 7 Missing ⚠️
vortex-array/src/arrays/null/compute/take.rs 55.55% 4 Missing ⚠️
...ex-array/src/arrays/extension/compute/is_sorted.rs 50.00% 3 Missing ⚠️
vortex-array/src/arrays/null/compute/filter.rs 0.00% 3 Missing ⚠️
vortex-array/src/arrays/null/compute/mask.rs 0.00% 3 Missing ⚠️
vortex-array/src/arrays/null/compute/min_max.rs 0.00% 3 Missing ⚠️
...ex-array/src/arrays/struct_/compute/is_constant.rs 93.75% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20 connortsui20 merged commit 3e79554 into develop Oct 17, 2025
41 checks passed
@connortsui20 connortsui20 deleted the ct/compute-files branch October 17, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants