refactor: clarify the tally report types #791
Conversation
| <NoWrap>Tally Report</NoWrap> | ||
| </h1> | ||
| <p> | ||
| This report should be <strong>{reportPurpose}</strong>. | ||
| </p> | ||
| <p> | ||
| {isPollsOpen ? 'Polls Closed' : 'Polls Opened'} and report printed at:{' '} | ||
| {isPollsOpen ? 'Polls Closed' : 'Polls Opened'} and report printed at: |
There was a problem hiding this comment.
Please confirm that there is still a space after the : in the rendered content.
There was a problem hiding this comment.
I didn't even know this happened because eslint made this change for me. Here's what I see if I add it back in:
I'll check that the space is still there.
There was a problem hiding this comment.
Turns out this was due to a bug that's now fixed: jsx-eslint/eslint-plugin-react#2437. I'll update eslint-plugin-react in your PR.
| @@ -54,14 +60,14 @@ const PrecinctTallyReport = ({ | |||
| return ( | |||
| <Report> | |||
| <h1> | |||
| <NoWrap>{precinct.name}</NoWrap> <NoWrap>{election.title}</NoWrap>{' '} | |||
| <NoWrap>{precinct.name}</NoWrap> <NoWrap>{election.title}</NoWrap> | |||
There was a problem hiding this comment.
Please confirm that there is still a space between the election title and "Tally Report" in the rendered content.
|
Sorry to make you rebase… I was just doing what you asked. 😝 |
This changes the types for the candidate and yesno tallies from arrays into objects. For candidate contests, it splits the former single array that contained both write-ins and ballot candidates into separate properties on an object. For yesno contests, instead of a 2-element tuple we now have an object with "yes" and "no" properties. I think this is simpler and requires less casting. It also adds a few assertions for situations which shouldn't happen but otherwise might silently fail.
eventualbuddha
force-pushed
the
tally-report-types
branch
from
c3e94c8 to
f6c684c
Compare
No problem! Glad to see the improvements. |
This changes the types for the candidate and yesno tallies from arrays into objects. For candidate contests, it splits the former single array that contained both write-ins and ballot candidates into separate properties on an object. For yesno contests, instead of a 2-element tuple we now have an object with "yes" and "no" properties.
I think this is simpler and requires less casting. It also adds a few assertions for situations which shouldn't happen but otherwise might silently fail.