Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstable next index paging ref, remove filtering re-render #3249

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Remove unstable next index paging ref, remove filtering re-render #3249

merged 1 commit into from
Jul 4, 2023

Conversation

benjaminpkane
Copy link
Contributor

On 0.21.1 and flashlight reset is caused by an unstable next index ref and an extra filtering re-render. Setting the isMatching default to true and removing the unstable next ref resolves the issue.

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Jul 3, 2023
@benjaminpkane benjaminpkane requested a review from lanzhenw July 3, 2023 18:42
@benjaminpkane benjaminpkane self-assigned this Jul 3, 2023
@benjaminpkane benjaminpkane changed the base branch from develop to release/v0.21.2 July 3, 2023 18:42
@benjaminpkane benjaminpkane mentioned this pull request Jul 3, 2023
Closed
6 tasks
@benjaminpkane benjaminpkane merged commit f0085d5 into release/v0.21.2 Jul 4, 2023
@benjaminpkane benjaminpkane deleted the bug/filtering-and-paging branch July 4, 2023 01:26
benjaminpkane added a commit that referenced this pull request Jul 4, 2023
@benjaminpkane
remove next index ref, fix string filter is matching default (#3249)
d918c6a
benjaminpkane added a commit that referenced this pull request Jul 5, 2023
@benjaminpkane
Release v0.21.2 (#3251)
20b0b6e 
* update sidebar test, fix small regressions (#3250)

* remove next index ref, fix string filter is matching default (#3249)

* release notes

* package bumps

* disabled e2e

* lint

* fix mac arm64

* Teams v1.3.2 release note

* rm e2e

* add main
benjaminpkane added a commit that referenced this pull request Jul 5, 2023
@benjaminpkane
Release v0.21.2 (#3251) (#3255)
1a4c3ca 
* update sidebar test, fix small regressions (#3250)

* remove next index ref, fix string filter is matching default (#3249)

* release notes

* package bumps

* disabled e2e

* lint

* fix mac arm64

* Teams v1.3.2 release note

* rm e2e

* add main
benjaminpkane added a commit that referenced this pull request Jul 12, 2023
@benjaminpkane @lanzhenw
@manivoxel51 @brimoor @imanjra @findtopher @jacobmarks @AyushExel @NeoKish @kaixi-wang
Release/v0.21.3 (#3282)
b5ae567 
* Refactor schemaControls, use selectField() when searching, cleaner schema documentation

selection mode is default now for filed visibility

* update count dependency to refelct when applying filter rules

* add documentation links

* better disable field handling - (un)select is broken - fixing next

* improve select all control

* uncheck subpaths even if they are disabled

* show embedded document in selection mode

* field doc type using tertiary text color

* minor tweaks in color modal title style

* review comments and fix include nested fields selection view

* review comments, refactor selection row, and count fix

* add first vitest for visibility, upgrade vitest packages

* add basic test and refactor more

* keep one embed doc field

* no coverage when yarn test

* add support for multi-select with string type

* adds a Docker Hub Pulls badge

* Typo

* tweaking

* lint

* Add files via upload

* Update brain.rst

* Update index.rst

* Update index.rst

* Update index.rst

* Update index.rst

* Release v0.21.2 (#3251) (#3255)

* update sidebar test, fix small regressions (#3250)

* remove next index ref, fix string filter is matching default (#3249)

* release notes

* package bumps

* disabled e2e

* lint

* fix mac arm64

* Teams v1.3.2 release note

* rm e2e

* add main

* add icon

* typo

* first pass at milvus integration docs

* adding milvus to user_guide/brain

* adding to integrations index

* adding milvus logo

* square image, lower resolution

* editing pass

* consistency

* bugfixes

* disable field unit testing

* group and video dataset unit tests disabled

* toPatches disabling tests

* toClips

* label types test

* more granular field selection when disabling label subfields

* geolocation, heatmap, segmentation tests

* complete disabling test

* review comments

* enable vector fields, disable top level id field, more grnular disabling of FrameSupportField and FrameNumberField

* disable list of valid labels from visibility toggle

* review comments

* linting

* editing pass

* tweaks

* cleanup

* fixing capitalization

* adding new vector integrations

* bumping package versions

* adding release notes

* or count label tags (#3267)

* has group slices only when group dataset (#3262)

* Updating `Session.close()` (#3253)

* kill server on session close

* close desktop app

* cleanup

* lint

* lint

* is_open

* rm remote warning

* Embedded frame label fixes (#3256)

* add frame cases to dynamic label tests

* embedded frame label fixes

* linting

* adding a merge_sample() method

* Minor typo fixes

* adding test for one() method

* updating release notes

* tweak

* documenting list bucket perms

* Fix sidebar matching on label fields (#3270)

* only matches

* db_field bug and path fix

* Suppress errors due to none fields (#3275)

* don't throw error

* add debug msg

* import order

* Fixing #3277 (#3279)

* fixing filter_keypoints() bug

* adding dynamic doc test

* interactive typo fix for Dave

* removing persistent dataset usage in unit tests

* Sidebar filtering tests and fixes (#3280)

* only matches

* db_field bug and path fix

* base image sample tests

* cleanup

* exclude bug

* rm onlyMatch

* frame and dynamic tests

* adding coverage

* keypoints fixes

* cleanup

* base image sample tests

* cleanup

* exclude bug

* rm onlyMatch

* frame and dynamic tests

* adding coverage

* keypoints fixes

* cleanup

* tweaks

* exclude no only matches

* add to release notes

* whitespace

* updating release notes

* Minor fixes (#3283)

* docs tweaks

* documenting cache=True feature

---------

Co-authored-by: manivoxel51 <mani@voxel51@gmail.com>
Co-authored-by: Lanny W <lanzhenwang9@gmail.com>
Co-authored-by: manivoxel51 <109545780+manivoxel51@users.noreply.github.com>
Co-authored-by: Brian Moore <brian@voxel51.com>
Co-authored-by: imanjra <ibrahim@voxel51.com>
Co-authored-by: topher <topher@voxel51.com>
Co-authored-by: Jacob Marks <jamarks13@gmail.com>
Co-authored-by: brimoor <brimoor@umich.edu>
Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Co-authored-by: Kishan Savant <ksavant577@gmail.com>
Co-authored-by: Kacey <kacey@voxel51.com>
Co-authored-by: Kishan Savant <66986430+NeoKish@users.noreply.github.com>
@benjaminpkane benjaminpkane mentioned this pull request Jul 12, 2023
Merged
7 tasks
benjaminpkane added a commit that referenced this pull request Jul 12, 2023
@benjaminpkane @brimoor
@NeoKish @kaixi-wang @findtopher @lanzhenw @manivoxel51 @imanjra @jacobmarks @AyushExel
Release/v0.21.3 into develop (#3284)
5e43920 
* Release v0.21.2 (#3251)

* update sidebar test, fix small regressions (#3250)

* remove next index ref, fix string filter is matching default (#3249)

* release notes

* package bumps

* disabled e2e

* lint

* fix mac arm64

* Teams v1.3.2 release note

* rm e2e

* add main

* adding new vector integrations

* bumping package versions

* adding release notes

* or count label tags (#3267)

* has group slices only when group dataset (#3262)

* Updating `Session.close()` (#3253)

* kill server on session close

* close desktop app

* cleanup

* lint

* lint

* is_open

* rm remote warning

* Embedded frame label fixes (#3256)

* add frame cases to dynamic label tests

* embedded frame label fixes

* linting

* adding a merge_sample() method

* Minor typo fixes

* adding test for one() method

* updating release notes

* tweak

* documenting list bucket perms

* Fix sidebar matching on label fields (#3270)

* only matches

* db_field bug and path fix

* Suppress errors due to none fields (#3275)

* don't throw error

* add debug msg

* import order

* Fixing #3277 (#3279)

* fixing filter_keypoints() bug

* adding dynamic doc test

* interactive typo fix for Dave

* removing persistent dataset usage in unit tests

* Sidebar filtering tests and fixes (#3280)

* only matches

* db_field bug and path fix

* base image sample tests

* cleanup

* exclude bug

* rm onlyMatch

* frame and dynamic tests

* adding coverage

* keypoints fixes

* cleanup

* base image sample tests

* cleanup

* exclude bug

* rm onlyMatch

* frame and dynamic tests

* adding coverage

* keypoints fixes

* cleanup

* tweaks

* exclude no only matches

* add to release notes

* whitespace

* updating release notes

* Minor fixes (#3283)

* docs tweaks

* documenting cache=True feature

* Release/v0.21.3 (#3282)

* Refactor schemaControls, use selectField() when searching, cleaner schema documentation

selection mode is default now for filed visibility

* update count dependency to refelct when applying filter rules

* add documentation links

* better disable field handling - (un)select is broken - fixing next

* improve select all control

* uncheck subpaths even if they are disabled

* show embedded document in selection mode

* field doc type using tertiary text color

* minor tweaks in color modal title style

* review comments and fix include nested fields selection view

* review comments, refactor selection row, and count fix

* add first vitest for visibility, upgrade vitest packages

* add basic test and refactor more

* keep one embed doc field

* no coverage when yarn test

* add support for multi-select with string type

* adds a Docker Hub Pulls badge

* Typo

* tweaking

* lint

* Add files via upload

* Update brain.rst

* Update index.rst

* Update index.rst

* Update index.rst

* Update index.rst

* Release v0.21.2 (#3251) (#3255)

* update sidebar test, fix small regressions (#3250)

* remove next index ref, fix string filter is matching default (#3249)

* release notes

* package bumps

* disabled e2e

* lint

* fix mac arm64

* Teams v1.3.2 release note

* rm e2e

* add main

* add icon

* typo

* first pass at milvus integration docs

* adding milvus to user_guide/brain

* adding to integrations index

* adding milvus logo

* square image, lower resolution

* editing pass

* consistency

* bugfixes

* disable field unit testing

* group and video dataset unit tests disabled

* toPatches disabling tests

* toClips

* label types test

* more granular field selection when disabling label subfields

* geolocation, heatmap, segmentation tests

* complete disabling test

* review comments

* enable vector fields, disable top level id field, more grnular disabling of FrameSupportField and FrameNumberField

* disable list of valid labels from visibility toggle

* review comments

* linting

* editing pass

* tweaks

* cleanup

* fixing capitalization

* adding new vector integrations

* bumping package versions

* adding release notes

* or count label tags (#3267)

* has group slices only when group dataset (#3262)

* Updating `Session.close()` (#3253)

* kill server on session close

* close desktop app

* cleanup

* lint

* lint

* is_open

* rm remote warning

* Embedded frame label fixes (#3256)

* add frame cases to dynamic label tests

* embedded frame label fixes

* linting

* adding a merge_sample() method

* Minor typo fixes

* adding test for one() method

* updating release notes

* tweak

* documenting list bucket perms

* Fix sidebar matching on label fields (#3270)

* only matches

* db_field bug and path fix

* Suppress errors due to none fields (#3275)

* don't throw error

* add debug msg

* import order

* Fixing #3277 (#3279)

* fixing filter_keypoints() bug

* adding dynamic doc test

* interactive typo fix for Dave

* removing persistent dataset usage in unit tests

* Sidebar filtering tests and fixes (#3280)

* only matches

* db_field bug and path fix

* base image sample tests

* cleanup

* exclude bug

* rm onlyMatch

* frame and dynamic tests

* adding coverage

* keypoints fixes

* cleanup

* base image sample tests

* cleanup

* exclude bug

* rm onlyMatch

* frame and dynamic tests

* adding coverage

* keypoints fixes

* cleanup

* tweaks

* exclude no only matches

* add to release notes

* whitespace

* updating release notes

* Minor fixes (#3283)

* docs tweaks

* documenting cache=True feature

---------

Co-authored-by: manivoxel51 <mani@voxel51@gmail.com>
Co-authored-by: Lanny W <lanzhenwang9@gmail.com>
Co-authored-by: manivoxel51 <109545780+manivoxel51@users.noreply.github.com>
Co-authored-by: Brian Moore <brian@voxel51.com>
Co-authored-by: imanjra <ibrahim@voxel51.com>
Co-authored-by: topher <topher@voxel51.com>
Co-authored-by: Jacob Marks <jamarks13@gmail.com>
Co-authored-by: brimoor <brimoor@umich.edu>
Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Co-authored-by: Kishan Savant <ksavant577@gmail.com>
Co-authored-by: Kacey <kacey@voxel51.com>
Co-authored-by: Kishan Savant <66986430+NeoKish@users.noreply.github.com>

* Updating logo wall links (#3288)

* updating logo wall links

* better links

---------

Co-authored-by: brimoor <brimoor@umich.edu>
Co-authored-by: Kishan Savant <ksavant577@gmail.com>
Co-authored-by: Brian Moore <brian@voxel51.com>
Co-authored-by: Kacey <kacey@voxel51.com>
Co-authored-by: topher <topher@voxel51.com>
Co-authored-by: Kishan Savant <66986430+NeoKish@users.noreply.github.com>
Co-authored-by: manivoxel51 <mani@voxel51@gmail.com>
Co-authored-by: Lanny W <lanzhenwang9@gmail.com>
Co-authored-by: manivoxel51 <109545780+manivoxel51@users.noreply.github.com>
Co-authored-by: imanjra <ibrahim@voxel51.com>
Co-authored-by: Jacob Marks <jamarks13@gmail.com>
Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanzhenw lanzhenw Awaiting requested review from lanzhenw

Assignees

@benjaminpkane benjaminpkane

Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benjaminpkane